From: Carlo Arenas <carenas@gmail.com>
Date: Fri, 10 Sep 2021 20:20:18 GMT
Subject: Re: [PATCH v7 0/9] ssh signing: Add commit & tag signing/verification via SSH keys using ssh-keygen
Message-ID: <CAPUEspgfRtTNXcVkSQ2FOS87m-jOD_Rx60mH0VP4M58_cHaHug@mail.gmail.com>
In-Reply-To: <532d97e7-8c91-df6a-6d90-70668256f513@gigacodes.de>

ON Fri, Sep 10, 2021 at 12:49 PM Fabian Stelzer <fs@gigacodes.de> wrote:
>
> On 10.09.21 20:44, Junio C Hamano wrote:
>
> > Fabian Stelzer <fs@gigacodes.de> writes:
> >
> >> It it not so much an incompatibility but a hard bug in ssh-keygen of my
> >> own making :/
> >> There is nothing we can do on the git side to fix this since the
> >> find-principal call will always segfault no matter what.
> > So... we cannot do anythying utnil a corrected OpenSSH is made
> > available, but once we can link with a corrected one, do we need to
> > do anything further on the patches in your topic?
>
> OpenSSH will probably release a new version in October.

FWIW the crashing bug is only in master (I found it while testing
OpenBSD 7 beta).
AFAIK, once that is fixed the suite runs cleanly, but still does not
when run against
an OpenSSH 4.7 release (hadn't check why, but AFAIK wasn't the crash from what
I recall)

> I will send a new diff of my patch in a bit after the CI runs are
> through fixing a bug with some buffers that could sometimes lead to
> memory corruption (i war releasing a buffer while still iterating over
> its contents), a small test fix and a minor improvement using
> git_config_pathname instead of string.

notice that since your patches are already in next (and I know it is
late since I saw
your update), you need to send only incremental patches now, instead.

Carlo