From: Usman Akinyemi <usmanakinyemi202@gmail.com>
Date: Sun, 03 Aug 2025 01:27:38 GMT
Subject: Re: [PATCH v4 1/2] t/t1517: automate `git subcmd -h` tests outside a repository
Message-ID: <CAPSxiM978fqvC_TO8fKQrx=S4yPEkp3ZufTq+zv+Ws7zJx6yDg@mail.gmail.com>
In-Reply-To: <CALnO6CAPBsxg=-aXVUUJSKrPLWWPLGdEM=k5J=GVoh5fVTAhYQ@mail.gmail.com>

> > Hm—if we strip the suffix with ${cmd%.*}, do we need a p4.py pattern
> > too? Actually, at first I wondered why we need to strip the suffix at
> > all. My local Git produces only unsuffixed commands. But
> > bin-wrappers/git produces both p4 and p4.py; request-pull and
> > request-pull.sh; and several others. So I think stripping is probably
> > right, just drop the .py pattern.
>
> I think that using "instaweb.sh" instead of "instaweb" also causes
> this to fail on Windows, like:
>
> https://github.com/benknoble/git/actions/runs/16695826272/job/47259908953
I think this is expected breakage. Removing ".sh" makes the #TODO to pass.
>
> --
> D. Ben Knoble