From: Usman Akinyemi <usmanakinyemi202@gmail.com>
Date: Wed, 21 Oct 2026 22:03:57 GMT
Subject: Re: [PATCH] [Outreachy PATCH] t0001: avoid pipes in test scripts
Message-ID: <CAPSxiM-Kx1=s45W_cocO+wrcaTaH7qSdqAFBwqJ0rwFAB+k06Q@mail.gmail.com>
In-Reply-To: <pull.2260.git.1792299301663.gitgitgadget@gmail.com>

> diff --git a/t/t0001-init.sh b/t/t0001-init.sh
> index f1d227f271..e835afee68 100755
> --- a/t/t0001-init.sh
> +++ b/t/t0001-init.sh
> @@ -678,7 +678,7 @@ test_expect_success 'default ref format' '
>                 sane_unset GIT_DEFAULT_REF_STORAGE_FORMAT &&
>                 git init refformat
>         ) &&
> -       git version --build-options | sed -ne "s/^default-ref-storage-format: //p" >expect &&
> +       git version --build-options >build-options && sed -ne "s/^default-ref-storage-format: //p" build-options >expect &&
We can put this in two lines, something like this:

               git version --build-options >build-options &&
               sed -ne "s/^default-ref-storage-format: //p"
build-options >expect &&

>         git -C refformat rev-parse --show-ref-storage-format >actual &&

Thanks for the patch.