From: Charvi Mendiratta <charvi077@gmail.com>
Date: Wed, 21 Oct 2020 13:16:13 GMT
Subject: Re: [PATCH v4] t7201: put each command on a separate line
Message-ID: <CAPSFM5edytA_RR_ykYFnWdpbG8ThoESYh+JCSYQ83j4w8k1sDQ@mail.gmail.com>
In-Reply-To: <xmqq5z74bqgi.fsf@gitster.c.googlers.com>

On Wed, 21 Oct 2020 at 01:49, Junio C Hamano <gitster@pobox.com> wrote:
>
> Junio C Hamano <gitster@pobox.com> writes:
>
> > Charvi Mendiratta <charvi077@gmail.com> writes:
> >
> >> Modern practice is to avoid multiple commands per line,
> >> and instead place each command on its own line.
> >>
> >> Signed-off-by: Charvi Mendiratta <charvi077@gmail.com>
> >> ---
> >
> > This looks good, but I am wondering what happened between v3 and
> > v4.
> >
> > As you've demonstrated through the microproject that you can now
> > comfortably be involved in the review discussion, I am tempted to
> > suggest that we declare victory at this point and move on, but I
> > don't know what the plans are for the other 4 patches (I guess we
> > won't miss them that much---the micros are meant to be practice
> > targets).
>
> Actually I take it back.  This does not look good as a standalone
> patch at all.  It seems to depend on something in the 5-patch
> series.
>

Yes, Thanks a lot Junio. I totally agree after applying it locally and
getting stuck in am conflicts without using v3.

> Please make sure that patches you send are usable by your
> recipients.
>
I will take this as an important note. I have fixed it and sent the patch
series after testing it locally .

Thanks and Regards,
Charvi