From: Charvi Mendiratta <charvi077@gmail.com>
Date: Sun, 14 Mar 2021 13:57:58 GMT
Subject: Re: [PATCH v5 6/6] doc/git-commit: add documentation for fixup=[amend|reword] options
Message-ID: <CAPSFM5dE=3EDZZ1E=4SOyYWjOA=uNtHAWphruojPtfLCv7xuWg@mail.gmail.com>
In-Reply-To: <CAPig+cRQe3EURfXYQ9QwxfiSjJom3gZoZ_Q07ON4B+YgHu6dCw@mail.gmail.com>

On Sun, 14 Mar 2021 at 06:40, Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Sat, Mar 13, 2021 at 8:43 AM Charvi Mendiratta <charvi077@gmail.com> wrote:
> > Helped-by: Junio C Hamano <gitster@pobox.com>
> > Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
> > Signed-off-by: Charvi Mendiratta <charvi077@gmail.com>
>
> It may have been more accurate to retain the Helped-by: with my name
> while adding the Signed-off-by: (which I offered in case you
> incorporated my significant rewrites), rather than replacing the
> Helped-by: altogether. Not worth a re-roll, though.
>

Okay I will add that too, thanks.