From: Charvi Mendiratta <charvi077@gmail.com>
Date: Sun, 18 Oct 2020 05:40:39 GMT
Subject: Re: [PATCH v2 2/5][Outreachy] t7102,t7201: remove unnecessary blank spaces in test body
Message-ID: <CAPSFM5cWx0c2CRVXxBO5Xq8AoTPSGmRa9x1hZom=cRqpOO4WkQ@mail.gmail.com>
In-Reply-To: <20201017151358.GA2837@danh.dev>

On Sat, 17 Oct 2020 at 20:44, Đoàn Trần Công Danh <congdanhqx@gmail.com> wrote:
>
> On 2020-10-17 13:24:52+0530, Charvi Mendiratta <charvi077@gmail.com> wrote:
>
> Welcome to the list.
>
> > Some tests use a deprecated style in which there are unnecessary blank lines after the opening quote of the test body and before the closing quote. So we should remove these unnecessary blank lines.
>
> In Git project, we wrap the commit message's body to 72 columns per
> line (for more information, please take a look at
> Documentation/MyFirstContribution.txt).
>

Thanks a lot Danh, I will fix it in my editor's settings and will
update in the next patch series .

> And we rarely say "we should", if the change shouldn't be applied,
> it won't be applied.
> Instead, we ask the code base to fix itself. Perhaps:
>
>         t7102 and t7201 still follow the old style of having blank
>         lines around test body, which is not consistence with our
>         current practice.
>
>         Let's remove those unnecessary blank lines.
>

Noted, will update this as well.

> Thanks,
> --
> Danh

Thanks and Regards,
Charvi