From: Tao Klerks <tao@klerks.biz>
Date: Tue, 01 Mar 2022 09:59:53 GMT
Subject: Re: [PATCH v3 2/2] t3200: tests for new branch.autosetupmerge option "simple"
Message-ID: <CAPMMpoj6JM84v5kD8sFWG+157r9DHGckt9_uNrY6LMz3rQKA2w@mail.gmail.com>
In-Reply-To: <CAPig+cQQ30XZ1zAguZNgEMTFK3P029Ds-miXQq=A-_pd4HGiGQ@mail.gmail.com>

On Tue, Mar 1, 2022 at 3:59 AM Eric Sunshine <sunshine@sunshineco.com> wrote:
>
> On Mon, Feb 28, 2022 at 5:54 AM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
> > On Mon, Feb 28 2022, Tao Klerks via GitGitGadget wrote:
> > > +     test $(git config branch.feature.remote) = otherserver &&
> > > +     test $(git config branch.feature.merge) = refs/heads/feature
> >
> > Use:
> >
> >     echo otherserver >expect &&
> >     git config ... >actual &&
> >     test_cmp expect actual
> >
> > etc., the pattern you're using here will hide git's exit code on
> > segfaults, abort() etc., and also makes for less useful debug info on
> > failure than test_cmp.
>
> Better yet, use test_cmp_config():
>
>     test_cmp_config otherserver branch.feature.remote &&

Noted, thx.