From: Tao Klerks Date: Tue, 05 Apr 2022 11:29:49 GMT Subject: Re: [PATCH v4 00/22] git-p4: Various code tidy-ups Message-ID: In-Reply-To: On Tue, Apr 5, 2022 at 6:27 AM Tao Klerks wrote: > > On Mon, Apr 4, 2022 at 4:46 PM Joel Holdsworth wrote: > > > > > > Can you give me a bit more information about this, because I was going to try and push for the git-p4 to discard Python 2 support later this year in a bid to simplify the code, reduce the testing burden, and move toward cleaner pylint output. > > > > I'll try to look into this and see whether git-p4 itself can be made > to be more forgiving under python3, or whether there is an even better > solution where inconsistently-encoded Perforce metadata can somehow be > harmonized. Either way, I'll try to contribute some > test_expect_failure tests. So, an initial test suggests that a recent version of git-p4 at least doesn't fail in the same way under python3, in the face of at least some of these encoding issues. I don't know yet whether failures will occur in other places, nor whether the not-failing behavior is better, worse or the same as I had under python2, but it seems plausible that I won't be filing any test_expect_failure tests after all, and will instead say "yay, python3 ftw!"