From: Christian Couder <christian.couder@gmail.com>
Date: Thu, 27 Apr 2023 14:07:05 GMT
Subject: Re: [PATCH v2] attr: teach "--attr-source=<tree>" global option to "git"
Message-ID: <CAP8UFD3pqk1LrdA=FuRbfT+xHs4iBa6SxwmHUa1R7mXH5MmH-A@mail.gmail.com>
In-Reply-To: <CAP8UFD1YG-NnHbG4kBmh7L=O3wVnYKHCd94xD6Up_+AwK1ABPQ@mail.gmail.com>

On Thu, Apr 27, 2023 at 4:02 PM Christian Couder
<christian.couder@gmail.com> wrote:

> >      -    Add an environment variable GIT_ATTR_SOURCE that is set when
> >      -    --attr-source is passed in, so that subprocesses use the same value for
> >      -    the attributes source tree.
> >      +    Additionally, add an environment variable GIT_ATTR_SOURCE that is set
> >      +    when --attr-source is passed in, so that subprocesses use the same value
> >      +    for the attributes source tree.
> >
> >      -    Signed-off-by: Junio C Hamano <gitster@pobox.com>
> >           Signed-off-by: John Cai <johncai86@gmail.com>
>
> If the patch is from Junio, I think you should keep his Signed-off-by. If you

I wanted to say that if you take ownership of the patch as Junio
suggested, I think it should be Ok either way.