From: Christian Couder <christian.couder@gmail.com>
Date: Fri, 05 Aug 2016 07:59:22 GMT
Subject: Re: [PATCH 3/7] trace: use warning() for printing trace errors
Message-ID: <CAP8UFD3hvrrwmnyF0PLreAos62hN_1W4bwYV9toMQ-vQQ6rgog@mail.gmail.com>
In-Reply-To: <xmqqy44cz0k6.fsf@gitster.mtv.corp.google.com>

On Thu, Aug 4, 2016 at 11:28 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
>
>> I wondered if that would then let us drop set_warn_routine(), but it
>> looks like there are other warning() calls it cares about. So that would
>> invalidate the last paragraph here, though I still think converting the
>> trace errors to warning() is a reasonable thing to do.
>
> Yes.  That is why tonight's pushout will have this series in 'jch'
> (that is a point on a linear history between 'master' and 'pu') and
> tentatively ejects cc/apply-am topic out of 'pu', expecting it to be
> rerolled.

Ok, I will reroll soon with Peff's suggested changes.