From: Christian Couder <christian.couder@gmail.com>
Date: Wed, 02 Apr 2014 06:02:35 GMT
Subject: Re: [PATCH v9 08/11] trailer: add tests for "git interpret-trailers"
Message-ID: <CAP8UFD3dr=p-=zf5Dt4YZA0DEGaqMtFd3GuAzJnC1fPyvUn2Kw@mail.gmail.com>
In-Reply-To: <xmqqa9c4y823.fsf@gitster.dls.corp.google.com>

On Wed, Apr 2, 2014 at 12:54 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> +test_expect_success '--trim-empty without config' '
>> +     cat >expected <<-\EOF &&
>> +             ack: Peff
>> +             Acked-by: Johan
>> +     EOF
>> +     git interpret-trailers --trim-empty "ack = Peff" "Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
>> +     test_cmp expected actual
>> +'
>
> Let's avoid these overlong and unreadable lines by doing something
> like this (just one hunk shown for illustration):
>
>                 ack: Peff
>                 Acked-by: Johan
>         EOF
> -       git interpret-trailers --trim-empty "ack = Peff" "Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
> +       git interpret-trailers --trim-empty "ack = Peff" \
> +               "Reviewed-by" "Acked-by: Johan" "sob:" >actual &&
>         test_cmp expected actual
>  '

Ok.

> I've queued the series on 'pu' with the 'chop-overlong-lines' and
> another minor fix squashed in; hopefully we can merge to 'next'
> soonish.

Great!

Thanks,
Christian.