From: Christian Couder <christian.couder@gmail.com>
Date: Thu, 19 Apr 2018 10:09:36 GMT
Subject: Re: [PATCH v2 2/7] replace: introduce --convert-graft-file
Message-ID: <CAP8UFD3cH4JkKo97o4k+BW=sdaFviJR06R1V_JqS9FkwuP7ZKw@mail.gmail.com>
In-Reply-To: <cecb82973f80fdd2db940410db2a7c3b23107c4b.1524125760.git.johannes.schindelin@gmx.de>

On Thu, Apr 19, 2018 at 10:17 AM, Johannes Schindelin
<johannes.schindelin@gmx.de> wrote:

> @@ -87,9 +88,13 @@ OPTIONS
>         content as <commit> except that its parents will be
>         [<parent>...] instead of <commit>'s parents. A replacement ref
>         is then created to replace <commit> with the newly created
> -       commit. See contrib/convert-grafts-to-replace-refs.sh for an
> -       example script based on this option that can convert grafts to
> -       replace refs.
> +       commit. Use `--convert-graft-file` to convert a
> +       `$GIT_DIR/info/grafts` file use replace refs instead.

s/file use replace refs/file to use replace refs/

> +--convert-graft-file::
> +       Creates graft commits for all entries in `$GIT_DIR/info/grafts`
> +       and deletes that file upon success. The purpose is to help users
> +       with transitioning off of the now-deprecated graft file.

I wonder if it would be better to rename the file to "old_grafts" or
something, and perhaps tell the user that we renamed it and it can now
be either deleted or moved somewhere else.

Thanks for working on this,
Christian.