From: Christian Couder <christian.couder@gmail.com>
Date: Wed, 27 Apr 2016 13:31:49 GMT
Subject: Re: [PATCH 05/83] builtin/apply: extract line_by_line_fuzzy_match() from match_fragment()
Message-ID: <CAP8UFD3SMRqX2=gNZteOe1A0+LT=nfG4HFg+Udtnobp1t+gBPA@mail.gmail.com>
In-Reply-To: <xmqqbn4wf7ft.fsf@gitster.mtv.corp.google.com>

On Tue, Apr 26, 2016 at 10:20 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Christian Couder <christian.couder@gmail.com> writes:
>
>>> It's not clear why we need to declare buf here? Oh wait it is. It's just
>>> moved from the start of the function. But why do it in this patch?
>>> It seems unrelated to the general intent of the patch. No need to reroll
>>> for this nit alone, it just took me a while to figure out it was an unrelated
>>> thing.
>>
>> Yeah, I agree it's a bit unrelated. But rather than add another patch
>> to an already long series just for this,...
>
> Isn't not doing the unrelated move at all a more sensible
> alternative, if that change does not deserve its own place in the
> series after all?

Ok, I removed the unrelated move.