From: Christian Couder Date: Fri, 03 Jul 2026 07:10:19 GMT Subject: Re: [PATCH v8 00/11] builtin/history: introduce "drop" subcommand Message-ID: In-Reply-To: <20260701-b4-pks-history-drop-v8-0-19b5cdf1facd@pks.im> On Wed, Jul 1, 2026 at 1:35 PM Patrick Steinhardt wrote: > > Hi, > > this small patch series introduces the new "drop" subcommand for > git-history(1). As a reader might guess, the command does exactly that: > given a commit, it will drop that commit from the commit history and > replay descendant branches on top of it. > > Changes in v8: > - Pass `RESOLVE_REF_READING` to make `refs_resolve_ref_unsafe()` > return a NULL pointer when it cannot resolve the reference. > - Drop unneeded code that sets `head_target = "HEAD"` on detached > HEAD. > - Add a test case that verifies that we can drop commits with > "--update-refs=head" and a detached HEAD. > - Link to v7: https://patch.msgid.link/20260629-b4-pks-history-drop-v7-0-6e9392a957d8@pks.im Except for the style nit in patch 6 (spurious space character), this series looks good to me. Thanks.