From: Christian Couder <christian.couder@gmail.com>
Date: Thu, 01 Sep 2016 08:03:49 GMT
Subject: Re: [PATCH v13 02/14] apply: rename and move opt constants to apply.h
Message-ID: <CAP8UFD3DS_AV_ATH8Z9v0f0y4zFjhjhD0h9LfHwnJ2R0Fm5EqQ@mail.gmail.com>
In-Reply-To: <CAGZ79kYzOh-trnnc2JH9QX21DX=6nz=q0M99tbpU_Q68tmH0Qw@mail.gmail.com>

On Wed, Aug 31, 2016 at 11:46 PM, Stefan Beller <sbeller@google.com> wrote:
> On Sat, Aug 27, 2016 at 11:45 AM, Christian Couder
> <christian.couder@gmail.com> wrote:
>>  extern int check_apply_state(struct apply_state *state, int force_apply);
>>
>
> With greater scope comes greater responsibility. Nit of the day:
> In case a reroll is necessary, consider putting a comment here.
> (What are these constants? what do they control? How/where do I use them?)
>
>> +#define APPLY_OPT_INACCURATE_EOF       (1<<0)
>> +#define APPLY_OPT_RECOUNT              (1<<1)

Ok I will reroll with some added comments.