From: Christian Couder <christian.couder@gmail.com>
Date: Tue, 02 Aug 2011 07:52:44 GMT
Subject: Re: [RFC/ PATCH] revert: Allow arbitrary sequencer instructions
Message-ID: <CAP8UFD367s-0gSbmX7N3Ddakc1cZxWb_eU-+Uy5Vr0gbY8m8SA@mail.gmail.com>
In-Reply-To: <1312260884-5087-2-git-send-email-artagnon@gmail.com>

Hi Ram,

On Tue, Aug 2, 2011 at 6:54 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
>
>        if (get_sha1(sha1_abbrev, commit_sha1) < 0)
>                return NULL;
>
> -       return lookup_commit_reference(commit_sha1);
> +       commit = lookup_commit_reference(commit_sha1);
> +       if (commit) {
> +               insn = xmalloc(sizeof(struct replay_insn));
> +               insn->commit = commit;
> +               insn->action = action;
> +               return insn;
> +       }
> +       return NULL;
>  }

I'd suggest:

       commit = lookup_commit_reference(commit_sha1);
       if (!commit)
               return NULL;

       insn = xmalloc(sizeof(struct replay_insn));
       insn->commit = commit;
       insn->action = action;
       return insn;

Thanks,
Christian.