From: Christian Couder <christian.couder@gmail.com>
Date: Sun, 08 Jun 2014 06:49:45 GMT
Subject: Re: [PATCH v3 1/4] replace: add --graft option
Message-ID: <CAP8UFD344NFECqtO-uK-2wHA7XEko3XMJWuhW9+KGBdaiqGq+w@mail.gmail.com>
In-Reply-To: <CAP8UFD2u-DReCv2ZXhAzH_UMW5P--+a=AKS-N88xE6zmdWBLqQ@mail.gmail.com>

On Fri, Jun 6, 2014 at 5:44 PM, Christian Couder
<christian.couder@gmail.com> wrote:
>
>         /* find existing parents */
>         strbuf_addstr(&buf, commit->buffer);

Unfortunately, it looks like the above will not work if the commit->buffer
contains an embedded NUL. I wonder if it is a real problem or not.