From: Christian Couder <christian.couder@gmail.com>
Date: Tue, 28 Jul 2015 09:13:50 GMT
Subject: Re: [RFC/PATCH 02/11] ref-filter: add 'colornext' atom
Message-ID: <CAP8UFD2x5rz18hUXmJVWw81EMEVZc5Hm=_GUwfuc6Fo--8Ukfw@mail.gmail.com>
In-Reply-To: <1438066594-5620-2-git-send-email-Karthik.188@gmail.com>

On Tue, Jul 28, 2015 at 8:56 AM, Karthik Nayak <karthik.188@gmail.com> wrote:
> @@ -712,6 +713,15 @@ static void populate_value(struct ref_array_item *ref)
>                         v->modifier_atom = 1;
>                         v->pad_to_right = 1;
>                         continue;
> +               } else if (starts_with(name, "colornext:")) {
> +                       char color[COLOR_MAXLEN] = "";
> +
> +                       if (color_parse(name + 10, color) < 0)
> +                               die(_("unable to parse format"));

Maybe use skip_prefix(), and die() with a more helpful message.

> +                       v->s = xstrdup(color);
> +                       v->modifier_atom = 1;
> +                       v->color_next = 1;
> +                       continue;
>                 } else
>                         continue;