From: Christian Couder <christian.couder@gmail.com>
Date: Sun, 31 Jul 2011 19:21:51 GMT
Subject: Re: [PATCH v8 4/7] bisect: introduce --no-checkout, --update-ref=<ref> support into porcelain.
Message-ID: <CAP8UFD2vCGnejSj=Nwkb+kGCpwUaggh5j2V6zBu0iWqNZwvS3Q@mail.gmail.com>
In-Reply-To: <1312113321-28760-5-git-send-email-jon.seymour@gmail.com>

On Sun, Jul 31, 2011 at 1:55 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
>
> +       if test -n "$BISECT_UPDATE_REF"; then
> +           eval="$eval echo '$BISECT_UPDATE_REF' > '$GIT_DIR/BISECT_UPDATE_REF';"
> +       fi

I don't like this very much. In fact I realize that the eval thing we
use is buggy because the result of 'eval "eval"' will be the result of
the last command in "eval", so we won't detect if one of the first
command in "eval" failed.

So perhaps something like:

    eval "$eval" &&
+  ( test -n "$BISECT_UPDATE_REF" || echo "$BISECT_UPDATE_REF" >
"$GIT_DIR/BISECT_UPDATE_REF" ) &&
    echo "git bisect start$orig_args" >>"$GIT_DIR/BISECT_LOG" || exit

Thanks,
Christian.