From: Christian Couder Date: Fri, 10 Jan 2025 11:39:39 GMT Subject: Re: [PATCH v9 2/8] cat-file: add declaration of variable i inside its for loop Message-ID: In-Reply-To: <20250108183740.67022-3-eric.peijian@gmail.com> On Wed, Jan 8, 2025 at 7:38 PM Eric Ju wrote: > > Some code used in this series declares variable i and only uses it > in a for loop, not in any other logic outside the loop. > > Change the declaration of i to be inside the for loop for readability. It might be nice to say that, while at it, we also change the type from "int" to "size_t" where the latter makes more sense.