From: Christian Couder <christian.couder@gmail.com>
Date: Thu, 30 Jun 2016 09:50:44 GMT
Subject: Re: [PATCH v8 33/41] write_or_die: use warning() instead of fprintf(stderr, ...)
Message-ID: <CAP8UFD2kXp2Ugojq9ktudOB=tpcsm3fxe2XYKtRQ9KdzqTug-g@mail.gmail.com>
In-Reply-To: <xmqqoa6l6lia.fsf@gitster.mtv.corp.google.com>

On Tue, Jun 28, 2016 at 11:39 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Christian Couder <christian.couder@gmail.com> writes:
>
>> @@ -98,8 +97,7 @@ int write_or_whine_pipe(int fd, const void *buf, size_t count, const char *msg)
>>  int write_or_whine(int fd, const void *buf, size_t count, const char *msg)
>>  {
>>       if (write_in_full(fd, buf, count) < 0) {
>> -             fprintf(stderr, "%s: write error (%s)\n",
>> -                     msg, strerror(errno));
>> +             warning("%s: write error (%s)\n", msg, strerror(errno));
>>               return 0;
>>       }
>
> I do not think you call write_or_whine() at all.  As another topic
> in flight removes the last caller of this function, this hunk is
> very much unwelcome.  The only effect of it is to force me resolve
> unnecessary merge conflicts.

Ok, sorry about that. I will remove the hunk.