From: Christian Couder <christian.couder@gmail.com>
Date: Thu, 09 Oct 2025 12:33:15 GMT
Subject: Re: [PATCH 4/5] fast-export: handle all kinds of tag signatures
Message-ID: <CAP8UFD2g1usFU3fhV-8bdr8CCiipSOw=XuYGHrx3N8MUkVXjDQ@mail.gmail.com>
In-Reply-To: <aOYPWvdE4VnL8T7z@pks.im>

On Wed, Oct 8, 2025 at 11:21 AM Patrick Steinhardt <ps@pks.im> wrote:

> > diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh
> > index 21ff26939c..5a46608f65 100755
> > --- a/t/t9350-fast-export.sh
> > +++ b/t/t9350-fast-export.sh
> > @@ -279,6 +279,54 @@ test_expect_success 'signed-tags=warn-strip' '
> >       test -s err
> >  '
> >
> > +test_expect_success GPGSM 'setup X.509 signed tag' '
> > +
> > +     test_config gpg.format x509 &&
> > +     test_config user.signingkey $GIT_COMMITTER_EMAIL &&
> > +
> > +     git tag -s -m "X.509 signed tag" x509-signed $(git rev-parse HEAD) &&
> > +     ANNOTATED_TAG_COUNT=$((ANNOTATED_TAG_COUNT + 1))
> > +
> > +'
>
> Nit for this test and all of the below ones: our modern style does not
> have empty lines at the beginning and end of a test case.

Thanks. I think I have addressed all your comments like this one in
the v2 I just sent.