From: Christian Couder <christian.couder@gmail.com>
Date: Thu, 03 Jul 2014 14:17:20 GMT
Subject: Re: [PATCH v5 7/7] replace: add test for --graft with signed commit
Message-ID: <CAP8UFD2ddGr=cHSv06chD402k1dYrcQ=mxxWP+EHs48zE5twuA@mail.gmail.com>
In-Reply-To: <xmqqlhsbfocm.fsf@gitster.dls.corp.google.com>

On Wed, Jul 2, 2014 at 11:22 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Christian Couder <chriscool@tuxfamily.org> writes:
>
>>
>> +test_expect_success GPG 'set up a signed commit' '
>> +     echo "line 17" >> hello &&
>> +     echo "line 18" >> hello &&
>
> Style?

Yeah, I will change it to:

     echo "line 17" >>hello &&
     echo "line 18" >>hello &&

>> +     git add hello &&
>> +     test_tick &&
>> +     git commit --quiet -S -m "hello: 2 more lines in a signed commit" &&
>> +     HASH8=$(git rev-parse --verify HEAD) &&
>> +     git verify-commit $HASH8
>> +'
>> +
>> +test_expect_success GPG '--graft with a signed commit' '
>> +     git cat-file commit $HASH8 >orig &&
>> +     git replace --graft $HASH8 &&
>> +     git cat-file commit $HASH8 >repl &&
>> +     test_must_fail grep gpgsig repl &&
>> +     diff -u orig repl | grep "^-parent $HASH7" &&
>> +     diff -u orig repl | grep "^-gpgsig -----BEGIN PGP SIGNATURE-----" &&
>
> Almost the same comment as the one for 2/7 applies here.

Ok, I will find a way to make it better.

Thanks,
Christian.