From: Christian Couder <christian.couder@gmail.com>
Date: Sat, 11 Jun 2016 10:07:53 GMT
Subject: Re: [PATCH v6 41/44] am: use be_silent in 'struct apply_state' to shut up applying patches
Message-ID: <CAP8UFD2aP7gkLQpG1iFBpY-9wO2kPh8Os4E9RQc2Jtdve2QUqg@mail.gmail.com>
In-Reply-To: <xmqq4m90elz5.fsf@gitster.mtv.corp.google.com>

On Sat, Jun 11, 2016 at 12:07 AM, Junio C Hamano <gitster@pobox.com> wrote:
> The update in 33/44 to make am call into apply that is not ready to
> be called (e.g. the caller needs the dup(2) dance with /dev/null to
> be silent) gets finally corrected with this step, which makes the
> progress of the topic somewhat ugly and reviewing it a bit harder
> than necessary.  As it stands, the last several patches in the
> series smells more like "oops, we realize these things were not done
> properly the first time, and here are the follow-up patches to fix
> them up".
>
> I wonder if it is a good idea to delay integrating the apply
> machinery into "am" until it is ready?

Ok, I will do that and I think it should also avoid the build failures
on Windows.

Thanks,
Christian.