From: Christian Couder <christian.couder@gmail.com>
Date: Wed, 08 Oct 2025 09:42:20 GMT
Subject: Re: [PATCH 2/5] lib-gpg: allow tests with the GPGSM prereq first
Message-ID: <CAP8UFD2VRfZuaycCdWt4kpVpRv_UhNHdzqJ2vL8uyKJusUttnA@mail.gmail.com>
In-Reply-To: <aOYPTKG9t4ZB_Mbi@pks.im>

On Wed, Oct 8, 2025 at 11:21 AM Patrick Steinhardt <ps@pks.im> wrote:
>
> On Tue, Oct 07, 2025 at 02:29:55PM +0200, Christian Couder wrote:
> > diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh
> > index 937b876bd0..743985efab 100644
> > --- a/t/lib-gpg.sh
> > +++ b/t/lib-gpg.sh
> > @@ -38,7 +38,7 @@ test_lazy_prereq GPG '
> >               # To export ownertrust:
> >               #       gpg --homedir /tmp/gpghome --export-ownertrust \
> >               #               > lib-gpg/ownertrust
> > -             mkdir "$GNUPGHOME" &&
> > +             mkdir -p "$GNUPGHOME" &&
> >               chmod 0700 "$GNUPGHOME" &&
> >               (gpgconf --kill all || : ) &&
> >               gpg --homedir "${GNUPGHOME}" --import \
>
> Okay. I wonder why we even have to create the directory manually. We
> don't do it in the GPGSM prereq either, as gpgsm seems to handle this
> for us.

Yeah, the GPGSSH prereq does `mkdir -p "$GNUPGHOME"`, but not the GPGSM prereq.

> Doesn't `gpg --homedir ... --import` create the home directory
> in a similar way?

I am not sure. It might depend on the gpg version. Or maybe gpgsm
 does it but not gpg. I will check.