From: Christian Couder <christian.couder@gmail.com>
Date: Thu, 26 Feb 2026 13:03:36 GMT
Subject: Re: [Outreachy PATCH v7 0/3] store repo specific config values in new `struct repo_config_values`
Message-ID: <CAP8UFD2Rz3NMrTayi9yjRk4-51tStaLWKeBVB9RaJMWmiBLqrQ@mail.gmail.com>
In-Reply-To: <xmqqa4x7b0ba.fsf@gitster.g>

On Tue, Feb 17, 2026 at 9:08 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Olamide Caleb Bello <belkid98@gmail.com> writes:
>
> > Changes in v7:
> > ==============
> > - Added the code to reset the initialization of the_repository
> >   in the fuzz-commit-graph test in Patch 1.
> > - Changed the call to rep_config_values_init() in
> >   initialze_repository() by passing it the repo config_values_private_
> >   struct instead of the accessor function in Patch 1.
> > - Modified the commit message in Patch 1
> > - Added extra lines between variable declarations and code
>
> >      +struct repo_config_values *repo_config_values(struct repository *repo)
> >      +{
> >     ++        if (repo != the_repository)
> >     ++                BUG("trying to read config from wrong repository instance");
> >      +        if(!repo->initialized)
>
> $ git clang-format --diff $(git merge-base master HEAD)
>
> would have pointed out the style issue here.
>
> Will amend while queuing but it would be a bit before I can get to
> this patch set for real reviews.

I took another look at the series and found only another nit (a
missing blank line). Otherwise the series looks good to me.

Thanks.