From: Christian Couder Date: Tue, 11 Apr 2017 10:12:05 GMT Subject: Re: What's cooking in git.git (Apr 2017, #01; Tue, 11) Message-ID: In-Reply-To: > * cc/split-index-config (2017-03-30) 1 commit > - read-cache: avoid using git_path() in freshen_shared_index() > > The split-index code configuration code used an unsafe git_path() > function without copying its result out. > > Needs to be explained better. > The code looked OK, though. In: http://public-inbox.org/git/xmqq7f367o0s.fsf@gitster.mtv.corp.google.com/ it looked like you were ok with the explanation or you actually wanted it to be shorter. So should I send a shorter one? Or should I add explanation about why git_path() is unsafe?