From: Christian Couder <christian.couder@gmail.com>
Date: Fri, 02 Oct 2026 08:57:07 GMT
Subject: Re: [PATCH v4 5/5] builtin/upload-pack: don't disable lazy fetching on trusted repo
Message-ID: <CAP8UFD2Ks9mJ+Gdw02VXjpKv16HTxXTtQ3_5_heP_1TOfsHb-A@mail.gmail.com>
In-Reply-To: <xmqqse2sgda6.fsf@gitster.g>

On Tue, Sep 29, 2026 at 7:47 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Christian Couder <christian.couder@gmail.com> writes:

> > +uploadpack.lazyFetchTrusted::
> > +     A multi-valued configuration variable, each of which contains the
> > +     absolute local path of a repository that `upload-pack` is allowed to
> > +     lazily fetch missing objects for.
>
> "each of which" lacks a plural noun to modify.  Perhaps
>
>         each value of which specifies the absolute local path of a

Yeah, "each value of which specifies" is used in the v5 I just sent.

>         repository from which upload-pack is allowed to lazily fetch

"from which" would not be quite right, because the client would lazily
fetch from the promisor remotes of this server repo (using the
"promisor-remote" capability), not directly from this repo. So the
rest of the sentence hasn't changed in v5.

>         missing objects.
>
> > ++
> > +A repository is identified by its git directory, i.e. the `.git`
>
> "i.e." -> "i.e.," (similarly "e.g." -> "e.g.," below).

Applied in v5.

Thanks!