From: Christian Couder <christian.couder@gmail.com>
Date: Wed, 22 Oct 2025 13:56:34 GMT
Subject: Re: [Outreachy PATCH v5 1/2] gpg-interface: do not use misdesigned strbuf_split*()
Message-ID: <CAP8UFD2GCG5y7c=utQ43M=TfVPSDF0qUUAXH+U2nRpeuKfcW=w@mail.gmail.com>
In-Reply-To: <df8fbbd3a50748fd974083b6bbb07ffca91be465.1761135129.git.belkid98@gmail.com>

On Wed, Oct 22, 2025 at 2:40 PM Olamide Caleb Bello <belkid98@gmail.com> wrote:
>
> In get_ssh_finger_print(), the output of the `ssh-keygen` command is
> put into `fingerprint_stdout` strbuf.
> The string in `fingerprint_stdout` is then split into up to 3 strbufs

Nit: it's not clear if the first sentence of this commit message is
part of the same paragraph as the second sentence or not. If you
reroll this patch, I would suggest making it clearly part of the same
paragraph like this:

"In get_ssh_finger_print(), the output of the `ssh-keygen` command is
put into `fingerprint_stdout` strbuf. The string in `fingerprint_stdout` is
then split into up to 3 strbufs using strbuf_split_max(). However..."

Otherwise this patch looks fine to me.

Thanks.