From: Christian Couder <christian.couder@gmail.com>
Date: Wed, 15 Jul 2026 06:21:40 GMT
Subject: Re: [PATCH v5 4/4] environment: move has_symlinks into repo_config_values
Message-ID: <CAP8UFD2=FbbnCqWkTLEGBpz=90sh=j_70h2UJR=p4uj6u3tqMQ@mail.gmail.com>
In-Reply-To: <20260715035501.48271-5-cat@malon.dev>

On Wed, Jul 15, 2026 at 5:55 AM Tian Yuchen <cat@malon.dev> wrote:
>
> Move the global 'has_symlinks' configuration into the
> repository-specific 'repo_config_values' struct.
>
> To ensure code readability, the getter function
> 'repo_has_symlinks()' has been introduced. Callers access
> this configuration by passing in 'repo' when possible,
> and explicitly fall back to 'the_repository' the rest
> of the time.
>
> Note:
> To support early platform-specific (MinGW) overrides
> before repository initialization, a global variable
> 'default_has_symlinks' fallback is introduced as a fallback

It seems a bit redundant to use "fallback" twice in the above sentence.

> in environment.h. The *writer* in compat/mingw.c can only
> access this variable.

Otherwise this series looks good to me.

Thanks.