From: Christian Couder <christian.couder@gmail.com>
Date: Wed, 14 Feb 2024 14:26:51 GMT
Subject: Re: [PATCH v2 0/4] rev-list: allow missing tips with --missing
Message-ID: <CAP8UFD1xHq7nWXe4pQ8qFR4mjCZnSou06irDgZ-cR0FtscbsFg@mail.gmail.com>
In-Reply-To: <xmqq7cjemttr.fsf@gitster.g>

On Fri, Feb 9, 2024 at 12:15 AM Junio C Hamano <gitster@pobox.com> wrote:
>
> Christian Couder <christian.couder@gmail.com> writes:
>
> > # Patch overview
> >
> > Patches 1/4 (revision: clarify a 'return NULL' in get_reference()),
> > 2/4 (oidset: refactor oidset_insert_from_set()) and
> > 3/4 (t6022: fix 'test' style and 'even though' typo) are very small
> > preparatory cleanups.
> >
> > Patch 4/4 (rev-list: allow missing tips with --missing=[print|allow*])
> > allows git-rev-list(1) with `--missing=<arg>` when <arg> is not
> > 'error' to not fail if some tips it is passed are missing.
>
> Thanks.  There is an existing test that makes a bad assumption and
> fails with these patches.  We may need something like this patch as
> a preliminary fix before these four patches.

Thanks, I have added your patch to the V3 I just sent.