From: Christian Couder Date: Fri, 14 Aug 2026 17:12:39 GMT Subject: Re: [GSoC PATCH v5 0/6] repack: add --drop-filtered to reclaim space in partial clones Message-ID: In-Reply-To: <20260813200830.84348-1-r.siddharth.shrimali@gmail.com> On Thu, Aug 13, 2026 at 10:08 PM Siddharth Shrimali wrote: > Changes since v4: > * list-objects-filter: fixed the object-size local from "unsigned > long" to "size_t" to match object_info.sizep - caught by Junio > * list-objects-filter: made the filter options parameter const and > dropped the now-unnecessary cast at the call site - caught by Christian > * repack-filtered: comment fixes > * squashed the documentation into the patches it describes: the option > description now lands with "actually drop filtered promisor blobs" > and the guards paragraph with "add guards for --drop-filtered", > dropping the separate documentation patch, so the series is now 6 > patches - Suggested by Christian > * improved the "operation in progress" error message to name the > operations (merge, rebase, am, cherry-pick, revert, or bisect) > * swept test comments to be proper sentences and fixed tab or space > indentation Thanks. This version looks good to me.