From: Christian Couder <christian.couder@gmail.com>
Date: Sun, 31 May 2015 22:34:17 GMT
Subject: Re: [WIP/PATCH v4 8/8] ref-filter: add 'ref-filter.h'
Message-ID: <CAP8UFD1RnP1pk-MdzEBtiqTtpjaDyn-UZnEjCthrmHPYi1WCAA@mail.gmail.com>
In-Reply-To: <556B740A.5030404@gmail.com>

On Sun, May 31, 2015 at 10:50 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
> On 06/01/2015 02:16 AM, Matthieu Moy wrote:
>>
>> You can have a preparatory patch that adds ref-filter.c containing just
>> "#include ref-filter.h" and ref-filter.h with proper content. After this
>> preparatory patch, you're in a rather silly situation because you have
>> an almost empty .c file, but it's still passing all tests and
>> compileable.
>>
>> Then, the next patch can be just code movement.
>>
> Would it be okay, If I just include the Makefile addition along with the
> code movement
> from 'for-each-ref' to 'ref-filter.c' like Eric suggested?

Yeah, I think it is ok as well.