From: Christian Couder <christian.couder@gmail.com>
Date: Sun, 04 Sep 2016 16:45:53 GMT
Subject: Re: [PATCH v13 10/14] apply: change error_routine when silent
Message-ID: <CAP8UFD1Dssiw9=ME-084nXWd56X30vt1yEPYgyUnUjPsNcOVOw@mail.gmail.com>
In-Reply-To: <e39d9b83-949b-075c-07f6-60118dc24961@ramsayjones.plus.com>

On Sun, Sep 4, 2016 at 6:31 PM, Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
>
>
> On 04/09/16 11:54, Christian Couder wrote:
>> On Thu, Sep 1, 2016 at 10:19 AM, Christian Couder
>> <christian.couder@gmail.com> wrote:
>>> On Thu, Sep 1, 2016 at 12:20 AM, Stefan Beller <sbeller@google.com> wrote:
>>>>>
>>>>> +static void mute_routine(const char *bla, va_list params)
>>>>
>>>> Instead of 'bla' you could go with 'format' as the man page for
>>>> [f]printf puts it.
>>>> Or you could leave it empty, i.e.
>>>>
>>>>     static void mute_routine(const char *, va_list)
>>>>     ...
>>>
>>> Ok to do that.
>>
>> Actually I get the following error when doing that:
>>
>> apply.c: In function ‘mute_routine’:
>> apply.c:115:1: error: parameter name omitted
>>  static void mute_routine(const char *, va_list)
>>  ^
>> apply.c:115:1: error: parameter name omitted
>> make: *** [apply.o] Error 1
>
> Yes, this is not C++. ;-)
>
>> So I will leave it as is.
>
> I think I would prefer to see:
>
>     static void mute_routine(const char *msg, va_list params)
>
> given that it would either be an error-msg or a warning-msg.

Ok for "msg".