From: Christian Couder <christian.couder@gmail.com>
Date: Mon, 15 Mar 2021 10:00:30 GMT
Subject: Re: [PATCH v7] [GSOC] commit: add --trailer option
Message-ID: <CAP8UFD1+Z=hV_6dLbg7fh4EntBdWdheO6gvbQjKtZFRgOAsrzw@mail.gmail.com>
In-Reply-To: <pull.901.v7.git.1615799304883.gitgitgadget@gmail.com>

On Mon, Mar 15, 2021 at 10:08 AM ZheNing Hu via GitGitGadget
<gitgitgadget@gmail.com> wrote:

> @@ -166,6 +166,13 @@ The `-m` option is mutually exclusive with `-c`, `-C`, and `-F`.
>
>  include::signoff-option.txt[]
>
> +--trailer <token>[(=|:)<value>]::
> +       Specify a (<token>, <value>) pair that should be applied as a
> +       trailer. (e.g. `git commit --trailer "Signed-off-by:C O Mitter \
> +       <committer@example.com>" --trailer "Helped-by:C O Mitter \
> +       <committer@example.com>"` will add the "Signed-off" trailer

s/"Signed-off"/"Signed-off-by"/

> +       and the "Helped-by" trailer in the commit message.)

It might be useful to point users to git interpret-trailers'
documentation, for example by adding: "See
linkgit:git-interpret-trailers[1]."

Otherwise, this looks good to me!