From: Christian Couder <christian.couder@gmail.com>
Date: Thu, 05 Apr 2018 07:59:39 GMT
Subject: Re: [PATCH v5 2/5] stash: convert apply to builtin
Message-ID: <CAP8UFD0yz3yH7-fpxr=69z=wXAVjxraFWsuDVa7Ke_6ByV5B8Q@mail.gmail.com>
In-Reply-To: <CAP8UFD3SM9e+_VGpxVNzMoEYnyzkF0EzjAPjvbFakr9t9Z-muQ@mail.gmail.com>

On Thu, Apr 5, 2018 at 9:50 AM, Christian Couder
<christian.couder@gmail.com> wrote:
>
> So maybe we can get rid of `result` and have something like:
>
>        if (argc < 1) {
>                error(_("at least one argument is required"));
>                usage_with_options(git_stash_helper_usage, options);

Maybe we could also simplify these 2 lines by using usage_msg_opt().

>        }
>
>        if (!strcmp(argv[0], "apply"))
>                return apply_stash(argc, argv, prefix);
>
>        error(_("unknown subcommand: %s"), argv[0]);
>        usage_with_options(git_stash_helper_usage, options);
> }