From: Christian Couder <christian.couder@gmail.com>
Date: Fri, 25 Apr 2025 07:57:33 GMT
Subject: Re: [PATCH v4 4/5] meson: wire up benchmarks
Message-ID: <CAP8UFD0rq7Z=6PUPyPZOXaKyXzbWW7Eb0rDfoTxrd7k4Qo8ciQ@mail.gmail.com>
In-Reply-To: <20250425-pks-meson-benchmarks-v4-4-6b89555052c3@pks.im>

On Fri, Apr 25, 2025 at 9:28 AM Patrick Steinhardt <ps@pks.im> wrote:
>
> Wire up benchmarks in Meson. The setup is mostly the same as how we wire
> up our tests. The only difference is that benchmarks get wired up via
> the `benchmark()` option instead of via `test()`, which gives them a bit
> of special treatment:
>
>   - Benchmarks never run in parallel.
>
>   - Benchmarks aren't run by default when tests are executed.
>
>   - Meson does not inject the `MALLOC_PERTURB` environment variable.

[...]

> diff --git a/meson.build b/meson.build
> index 410bbf93dad..2cd05a9b1ba 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -70,6 +70,12 @@
>  #      # Execute single test interactively such that features like `debug ()` work.
>  #      $ meson test -i --test-args='-ix' t1400-update-ref
>  #
> +#      # Execute all benchmarks.
> +#      $ meson test -i --benchmark
> +#
> +#      # Execute single benchmark.
> +#      $ meson test -i --benchmark p0000-*
> +#
>  #   Test execution is parallelized by default and scales with the number of
>  #   processor cores available. You can change the number of processes by passing
>  #   the `-jN` flag to `meson test`.

Doesn't the above give the impression that benchmarks are also
parallelized by default while the commit message says they are not?