From: Christian Couder <christian.couder@gmail.com>
Date: Fri, 17 Jun 2016 16:18:56 GMT
Subject: Re: [PATCH v12 16/20] index-helper: don't run if already running
Message-ID: <CAP8UFD0qW3Xja2F3CyXzeA+-mVCAQ40iGcx6+xuvQnA2BBa3tA@mail.gmail.com>
In-Reply-To: <1463694357-6503-17-git-send-email-dturner@twopensource.com>

On Thu, May 19, 2016 at 11:45 PM, David Turner <dturner@twopensource.com> wrote:
>
> diff --git a/index-helper.c b/index-helper.c
> index 4a171e6..ddc641a 100644
> --- a/index-helper.c
> +++ b/index-helper.c
> @@ -438,6 +438,13 @@ int main(int argc, char **argv)
>                 return 0;
>         }
>
> +       /* check that no other copy is running */
> +       fd = unix_stream_connect(git_path("index-helper.sock"));
> +       if (fd > 0)
> +               die(_("Already running"));

I wonder is we should also die if fd == 0.