From: Christian Couder <christian.couder@gmail.com>
Date: Tue, 02 Aug 2011 12:16:05 GMT
Subject: Re: [PATCH v13 4/8] bisect: introduce support for --no-checkout option.
Message-ID: <CAP8UFD0kB+dS4cP=4MXKShhMw3-f_uKjtOmYKahNM0uQQkojsQ@mail.gmail.com>
In-Reply-To: <1312284545-2426-5-git-send-email-jon.seymour@gmail.com>

On Tue, Aug 2, 2011 at 1:29 PM, Jon Seymour <jon.seymour@gmail.com> wrote:
> If --no-checkout is specified, then the bisection process uses:

Yeah, but in this patch you are changing "git bisect--helper" by
adding the [--bisect-mode=checkout|update-ref] option. So it is
strange that you still talk about a --no-checkout option.

>        git update-ref --no-deref HEAD <trial>
>
> at each trial instead of:
>
>        git checkout <trial>

[...]

>  int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
>  {
>        int next_all = 0;
> +       int no_checkout = 0;
> +       char *bisect_mode=NULL;
>        struct option options[] = {
>                OPT_BOOLEAN(0, "next-all", &next_all,
>                            "perform 'git bisect next'"),
> +               OPT_STRING(0, "bisect-mode", &bisect_mode, "mode",
> +                           "the bisection mode either checkout or update-ref. defaults to checkout."),

Nit: I would say : "bisection mode: 'checkout' (default) or 'update-ref'"

Thanks,
Christian.