From: Christian Couder <christian.couder@gmail.com>
Date: Fri, 06 Aug 2021 09:06:03 GMT
Subject: Re: [GSoC] [PATCH 2/8] submodule--helper: remove repeated code in sync_submodule()
Message-ID: <CAP8UFD0hnkO+LMo2OTAiqPoi20V25806-zL97DA5qPz+3tgKnA@mail.gmail.com>
In-Reply-To: <YQyIJpq/r0O7zhb1@danh.dev>

On Fri, Aug 6, 2021 at 2:54 AM Đoàn Trần Công Danh <congdanhqx@gmail.com> wrote:

> While previous patch is definitely a refactoring, this patch add small
> overhead to the system, the new code will query (then free())
> git_config_get_string() and/or xgetcwd() one more time in the second
> compute_submodule_clone_url()
>
> I think the abstraction overhead is not that big, though.

Yeah, Junio made basically the same comment. So it would be nice if
the commit message could mention we are adding a very small overhead
in exchange for code simplification (10 lines removed).