From: Christian Couder Date: Sun, 15 Apr 2018 13:35:48 GMT Subject: Re: [PATCH v2] Make it possible to implement bisecting only on first parents or on merge commits by passing flags to find_bisection(), instead of just a find_all boolean Message-ID: In-Reply-To: <20180415104438.2046-1-haraldnordgren@gmail.com> On Sun, Apr 15, 2018 at 12:44 PM, Harald Nordgren wrote: > Signed-off-by: Harald Nordgren > --- > > Notes: > Updates according to Christian Couder's code review About the commit message (its first line and its body), I was suggesting a patch like the following: From 3a0ced0953ccc6038a43885d98a507eb18c19e42 Mon Sep 17 00:00:00 2001 From: Harald Nordgren Date: Sun, 15 Apr 2018 12:44:38 +0200 Subject: [PATCH] bisect: create 'bisect_flags' parameter in find_bisection() Make it possible to implement bisecting only on first parents or on merge commits by passing flags to find_bisection(), instead of just a 'find_all' boolean. Signed-off-by: Harald Nordgren --- bisect.c | 20 ++++++++++++-------- bisect.h | 6 ++++-- builtin/rev-list.c | 6 +++--- 3 files changed, 19 insertions(+), 13 deletions(-) ... The rest of the patch looks good to me. Thanks!