From: Christian Couder <christian.couder@gmail.com>
Date: Thu, 20 Aug 2015 16:53:18 GMT
Subject: Re: Minor annoyance with 'git interpret-trailers'
Message-ID: <CAP8UFD0YcBdAfMJxc2bQD_zTp+kPk2L2sQfWYzTDn+trFk+DMA@mail.gmail.com>
In-Reply-To: <vpqy4h5ud9z.fsf@anie.imag.fr>

On Thu, Aug 20, 2015 at 6:37 PM, Matthieu Moy
<Matthieu.Moy@grenoble-inp.fr> wrote:
> Hi,
>
> I use 'git interpret-trailers' as a commit-msg hook to add a
> Signed-off-by in a repository.
>
> When used in a one-line commit message formatted like
> 'foo: do something', the command interprets the one-line summary as a
> trailer, and inserts my Signed-off-by after it, without a blank line:
>
>     foo: do something
>     Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
>
> This breaks the convention "One summary line, one blank line, and then
> body", and shows my sign-off in the output of "git log --oneline" :-(.
>
> I think the behavior "don't insert a newline if the last line looks like
> a trailer" should be disabled when the message is a one-liner.

Yeah, I agree. I will take a look at fixing that soon.

Thanks for the report,
Christian.