From: Christian Couder <christian.couder@gmail.com>
Date: Tue, 21 Jan 2020 07:05:34 GMT
Subject: Re: [PATCH 10/29] bisect: libify `handle_bad_merge_base` and its dependents
Message-ID: <CAP8UFD0TU9FQQfk6SgDtOi+_eDni0ZJf+Bw-uN_LzAdeVh3HvQ@mail.gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.2001202321210.46@tvgsbejvaqbjf.bet>

On Mon, Jan 20, 2020 at 11:23 PM Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:

> On Mon, 20 Jan 2020, Miriam Rubio wrote:

> > @@ -777,14 +777,14 @@ static void handle_bad_merge_base(void)
> >                               "between %s and [%s].\n"),
> >                               bad_hex, term_bad, term_good, bad_hex, good_hex);
> >               }
> > -             exit(3);
> > +             return -3;
>
> ... which is: what does `3` stand for?

Maybe the question should have been answered by adding a comment to
the previous patch that added the `exit(3)` statement.

So yeah we could here add a separate patch that just adds such a comment.

Or maybe we can add such a comment in this patch and say something
like "while at it let's explain a bit the '3' error code" in the
commit message.