From: Christian Couder <christian.couder@gmail.com>
Date: Tue, 17 Aug 2021 09:23:13 GMT
Subject: Re: [PATCH v4 1/6] t6030-bisect-porcelain: add tests to control bisect run exit cases
Message-ID: <CAP8UFD0RFm=CBsckhdBJKJ9QAw+hWT0yY84J4dNcaXegRp4u0w@mail.gmail.com>
In-Reply-To: <3dcf28af-1e75-0934-4663-3691b0efde1d@gmail.com>

On Tue, Aug 17, 2021 at 11:03 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 17/08/21 15.14, Miriam Rubio wrote:
>
> > +test_expect_success 'bisect run fails with exit code equals or greater than 128' '
> > +     write_script test_script.sh <<-\EOF &&
> > +     exit 128 >/dev/null
> > +     EOF
> > +     test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt
> > +'
>
> This only checks for exit code equals to 128. You should also check for
> exit code greater than 128, for example 255.
>
> > +
> > +test_expect_success 'bisect run fails with exit code smaller than 0' '
> > +     write_script test_script.sh <<-\EOF &&
> > +     exit -1 >/dev/null
> > +     EOF
> > +     test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt
> > +'
>
> This test looks OK, using -1 as representative of negative exit code.
> However, wording of test name can also be 'bisect run fails with
> negative exit code'.

Actually I am not sure that it makes sense to test an exit code
smaller than 0, as POSIX exit codes are between 0 and 255 (included).

For example:

$ bash -c 'exit -1'; echo $?
255

$ dash -c 'exit -1'; echo $?
dash: 1: exit: Illegal number: -1
2