From: Christian Couder Date: Tue, 15 Mar 2022 08:50:26 GMT Subject: Re: [GSOC] [PATCH 1/1] t7403: Use helper function 'test_path_is_dir' to check if the path is a directory Message-ID: In-Reply-To: <20220313105031.1081110-1-gaurijove@gmail.com> On Sun, Mar 13, 2022 at 11:50 AM JAYATI SHRIVASTAVA wrote: > > From: JAYATI SHRIVASTAVA Thanks for this patch! I am curious what tool you used to prepare and send it. This is not a big deal but when there is only one patch I think [PATCH] is preferred over [PATCH 1/1]. Also I think the 'From: JAYATI...' line is not nécessary if you are sending the patch using the same email address as what's in the 'From: JAYATI...' line. > To check whether the given path is a directory, use > the helper function 'test_path_is_dir' defined in the > test harness library instead of passing the -d flag to the test command It's nice to say why it's better to use functions like test_path_is_dir() rather than `test -d`. Also it looks like the last line could be formatted to be around the same length as previous lines, instead of being significantly longer. The sentence should end with a full stop. > Signed-off-by: JAYATI SHRIVASTAVA It's also not a big deal, but, unless it's really a personal preference, you might not want to use only uppercase letters for your name, as it's not usual here. > --- > t/t7403-submodule-sync.sh | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) The code change looks good to me.