From: Christian Couder <christian.couder@gmail.com>
Date: Sun, 31 May 2015 08:04:32 GMT
Subject: Re: [WIP/PATCH v4 6/8] for-each-ref: rename some functions and make them public
Message-ID: <CAP8UFD080Yuv-CYcDzAG0u6OV7Sqry=0s1HKoJbt5wfKjTNO3Q@mail.gmail.com>
In-Reply-To: <1433008411-8550-6-git-send-email-karthik.188@gmail.com>

On Sat, May 30, 2015 at 7:53 PM, Karthik Nayak <karthik.188@gmail.com> wrote:
>
> -static void sort_refs(struct ref_sort *sort, struct ref_array *array)
> +void sort_ref_array(struct ref_sort *sort, struct ref_array *array)

It is probably better to call the above function ref_array_sort()...

[...]

> -static struct ref_sort *default_sort(void)
> +/*  If no sorting option is given, use refname to sort as default */
> +struct ref_sort *ref_default_sort(void)

... especially since you call the above ref_default_sort()...

> -static int opt_parse_sort(const struct option *opt, const char *arg, int unset)
> +int opt_parse_ref_sort(const struct option *opt, const char *arg, int unset)

... and the above opt_parse_sort().