From: Christian Couder Date: Fri, 26 Jun 2026 06:55:27 GMT Subject: Re: [PATCH v3 4/4] connected: search promisor objects generically Message-ID: In-Reply-To: On Thu, Jun 25, 2026 at 10:22 PM Junio C Hamano wrote: > > Patrick Steinhardt writes: > > > When performing connectivity checks we have to figure out whether any of > > the new objects are promisor objects, as we cannot assume full > > connectivity if so. > > > > This check is performed by iterating through all packfiles in the > > repository and searching each of them for the given object. Of course, > > this mechanism is quite specific to implementation details of the object > > database, as we assume that it uses packfiles in the first place. > > > > Refactor the logic so that we instead use `odb_for_each_object_ext()` > > with an object prefix filter and the `ODB_FOR_EACH_OBJECT_PROMISOR_ONLY` > > flag. This will yield all objects that have the exact object name and > > that are part of a promisor pack in a generic way. > > > > Add a test to verify that we indeed use the optimization. > > OK. The new test is a good way to catch the issue we noticed in the > previous round, I guess. Looking good. Yeah, it looks ready to me too. Thanks.