From: Christian Couder Date: Thu, 12 May 2016 20:18:57 GMT Subject: Re: [PATCH v2 10/94] builtin/apply: move 'unidiff_zero' global into 'struct apply_state' Message-ID: In-Reply-To: On Thu, May 12, 2016 at 9:28 PM, Junio C Hamano wrote: > Christian Couder writes: > >> To libify the apply functionality the 'unidiff_zero' variable should >> not be static and global to the file. Let's move it into >> 'struct apply_state'. >> >> Reviewed-by: Stefan Beller >> Signed-off-by: Christian Couder >> --- > > Looks correct; I would have expected from the flow of thought in the > series that p_value and linenr that were already mentioned would be > the first two to be put in this, but that would have to wait until > more functions are taught to pass the state around, so this ordering > would probably be fine. Yeah, if the patches that put p_value and linenr into 'struct apply_state' were earlier in the series, they would have to pass the state around to a lot more functions, so they would have been very big.