From: Christian Couder <christian.couder@gmail.com>
Date: Wed, 20 Nov 2024 18:15:40 GMT
Subject: Re: [PATCH v2 09/10] midx: pass down `hash_algo` to `get_split_midx_filename_ext`
Message-ID: <CAP8UFD02a+ZfHo1L5qhbzD2r4bmhXadSj4sy0acPncnj4pcRpg@mail.gmail.com>
In-Reply-To: <20241119-374-refactor-midx-c-and-midx-write-c-to-not-depend-on-global-state-v2-9-e2f607174efc@gmail.com>

On Tue, Nov 19, 2024 at 4:47 PM Karthik Nayak <karthik.188@gmail.com> wrote:
>
> Similar to the previous commit, pass down `hash_algo` to
> `get_split_midx_filename_ext` and use `hash_to_hex_algop`.

I think we prefer explanations in commit messages to be a bit more
self-contained, and not to rely much only on other commit messages, or
links to a mailing list thread on a mailing list archive, or other
external content. It's better to err on the side of copying more.