From: Christian Couder Date: Fri, 02 Oct 2026 09:18:45 GMT Subject: Re: [PATCH v4 5/5] builtin/upload-pack: don't disable lazy fetching on trusted repo Message-ID: In-Reply-To: On Fri, Oct 2, 2026 at 10:57 AM Christian Couder wrote: > > On Tue, Sep 29, 2026 at 7:47 PM Junio C Hamano wrote: > > > > Christian Couder writes: > > > > +uploadpack.lazyFetchTrusted:: > > > + A multi-valued configuration variable, each of which contains the > > > + absolute local path of a repository that `upload-pack` is allowed to > > > + lazily fetch missing objects for. > > > > "each of which" lacks a plural noun to modify. Perhaps > > > > each value of which specifies the absolute local path of a > > Yeah, "each value of which specifies" is used in the v5 I just sent. > > > repository from which upload-pack is allowed to lazily fetch > > "from which" would not be quite right, because the client would lazily > fetch from the promisor remotes of this server repo (using the > "promisor-remote" capability), not directly from this repo. So the > rest of the sentence hasn't changed in v5. Actually "from which" would not be quite right, but not for the reason I just gave. Sorry. It is not about the client, nor about the "promisor-remote" capability. "uploadpack.lazyFetchTrusted" controls server-side lazy fetching. So when a repo is listed in that config option, the server's `upload-pack` (via `pack-objects`), while serving that repo, lazily fetches missing objects _for_ that repo (not from it). > > missing objects.